Skip to content

implement the complete keyspace feature #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 27, 2023
Merged

implement the complete keyspace feature #439

merged 1 commit into from
Dec 27, 2023

Conversation

andylokandy
Copy link
Collaborator

@pingyu
Copy link
Collaborator

pingyu commented Dec 15, 2023

What's wrong with #415 ?

@andylokandy
Copy link
Collaborator Author

What's wrong with #415 ?

This is the complete implementation and #415 seems not handy while I continued its work.

@andylokandy andylokandy marked this pull request as ready for review December 17, 2023 17:29
@andylokandy andylokandy changed the title apiv2 implement the complete keyspace feature Dec 17, 2023
pingyu
pingyu reviewed Dec 24, 2023
View reviewed changes
Copy link
Collaborator

@pingyu pingyu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM.

BTW, please fix the DCO error.

@andylokandy
Copy link
Collaborator Author

fix the DCO error.

I can not fix it unless force pushing. But since we are going to squash and merge, it'll be ok because github will generate a good commit with DCO.

pingyu
pingyu reviewed Dec 25, 2023
View reviewed changes
@andylokandy
Copy link
Collaborator Author

@pingyu Done. PTAL

pingyu
pingyu approved these changes Dec 26, 2023
View reviewed changes
Copy link
Collaborator

@pingyu pingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@iosmanthus PTAL~

@andylokandy andylokandy merged commit 1178d79 into tikv:master Dec 27, 2023
@andylokandy andylokandy mentioned this pull request Jan 2, 2024
Open
@pingyu pingyu mentioned this pull request Mar 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iosmanthus iosmanthus iosmanthus left review comments

@pingyu pingyu pingyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andylokandy @pingyu @iosmanthus