Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade to rust 1.84.1 #477

Merged
merged 1 commit into from
Mar 17, 2025
Merged

Conversation

pingyu
Copy link
Collaborator

@pingyu pingyu commented Mar 16, 2025

Changes

  • Upgrade to toolchain 1.84.1.
  • Change toolchain from stable to specified stable version to ensure the compatibility and reproducibility of CI.
    • Bump to next stable version will be done periodically manually.
  • Fix errors found by new toolchain.

@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 16, 2025
@pingyu pingyu changed the title chore: Upgrade to rust 1.84 chore: Upgrade to rust 1.84.1 Mar 16, 2025
@pingyu
Copy link
Collaborator Author

pingyu commented Mar 16, 2025

/cc @iosmanthus

@ti-chi-bot ti-chi-bot bot requested a review from iosmanthus March 16, 2025 10:47
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 16, 2025
Copy link

ti-chi-bot bot commented Mar 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iosmanthus, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [YuJuncen,iosmanthus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 17, 2025
Copy link

ti-chi-bot bot commented Mar 17, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-16 10:52:48.052562712 +0000 UTC m=+180061.736798793: ☑️ agreed by iosmanthus.
  • 2025-03-17 04:32:01.149887838 +0000 UTC m=+243614.834123930: ☑️ agreed by YuJuncen.

@ti-chi-bot ti-chi-bot bot merged commit 070af41 into tikv:master Mar 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants