-
Notifications
You must be signed in to change notification settings - Fork 136
transaction: Handle "commit ts expired" error #491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
src/common/errors.rs
Outdated
/// Placeholder for no error (taken away). | ||
#[default] | ||
#[error("No error")] | ||
NoError, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are this enum value referenced?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In following block in src/store/error.rs
:
impl<T: HasKeyErrors> HasKeyErrors for Result<T, Error> {
fn key_errors(&mut self) -> Option<Vec<Error>> {
match self {
Ok(x) => x.key_errors(),
Err(Error::MultipleKeyErrors(errs)) => Some(std::mem::take(errs)),
Err(e) => Some(vec![std::mem::take(e)]),
}
}
}
The std::mem::take
requires Default
.
Signed-off-by: Ping Yu <yuping@pingcap.com>
@iosmanthus: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@coocood: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: coocood, iosmanthus The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Ping Yu <yuping@pingcap.com> (cherry picked from commit ac95421)
Signed-off-by: Ping Yu <yuping@pingcap.com> (cherry picked from commit ac95421)
Signed-off-by: Ping Yu <yuping@pingcap.com> (cherry picked from commit ac95421)
As title.