Skip to content

vote: nominate hhwyt as tikv reviewer#226

Merged
zhangjinpeng87 merged 1 commit intotikv:masterfrom
glorv:hhwyt-as-reviewer
Feb 12, 2025
Merged

vote: nominate hhwyt as tikv reviewer#226
zhangjinpeng87 merged 1 commit intotikv:masterfrom
glorv:hhwyt-as-reviewer

Conversation

@glorv
Copy link
Contributor

@glorv glorv commented Jan 20, 2025

No description provided.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 20, 2025

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • zhangjinpeng87

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the dco-signoff: yes Indicates the PR's author has signed the dco. label Jan 20, 2025
@glorv
Copy link
Contributor Author

glorv commented Jan 20, 2025

@ti-chi-bot ti-chi-bot bot requested a review from zhangjinpeng87 January 20, 2025 03:34
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 20, 2025

@glorv: GitHub didn't allow me to request PR reviews from the following users: Connor1996, overvenus, v01dstar, LykxSassinator.

Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

@hhwyt

/cc @zhangjinpeng87 @Connor1996 @overvenus @v01dstar @LykxSassinator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@glorv glorv force-pushed the hhwyt-as-reviewer branch from 820877b to d1ca86a Compare January 20, 2025 03:35
Copy link
Member

@v01dstar v01dstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 20, 2025

@v01dstar: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 20, 2025

@overvenus: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 20, 2025

@LykxSassinator: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hhwyt
Copy link

hhwyt commented Jan 20, 2025

Thank you all so much.

Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 20, 2025

@Connor1996: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hhwyt
Copy link

hhwyt commented Feb 5, 2025

@zhangjinpeng87 PTAL, thx~

Copy link
Member

@zhangjinpeng87 zhangjinpeng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 12, 2025
@zhangjinpeng87 zhangjinpeng87 merged commit 3aeafe2 into tikv:master Feb 12, 2025
1 check passed
@glorv glorv deleted the hhwyt-as-reviewer branch February 12, 2025 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the dco. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants