feat(resourcemanager): load resource groups in the background #9336
Conversation
Signed-off-by: JmPotato <[email protected]>
ti-chi-bot
bot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
the
size/S
| go func() { | ||
| start := time.Now() | ||
| log.Info("start to load keyspace resource groups in the background") | ||
| if err := m.loadKeyspaceResourceGroups(start); err != nil { |
There was a problem hiding this comment.
This behavior is different from the old one if the background task failed(maybe due to IO errors). Silently omit the error may cause undefined behavior in some cases.
| return err | ||
| } | ||
| // This operation is potentially time-consuming when there are many keyspaces and resource groups. | ||
| // So we run it in a new goroutine to prevent it from blocking the leader startup. |
There was a problem hiding this comment.
If we move it to the background, could you please add reporting of resource group loading to the /ready API as well.
What problem does this PR solve?
Issue Number: close #9335, ref #9296.
What is changed and how does it work?
Check List
Tests
Release note