Skip to content

dep: upgrade etcd to 3.5.20#9352

Open
okJiang wants to merge 9 commits intotikv:masterfrom
okJiang:upgrade-etcd3.5.20
Open

dep: upgrade etcd to 3.5.20#9352
okJiang wants to merge 9 commits intotikv:masterfrom
okJiang:upgrade-etcd3.5.20

Conversation

@okJiang
Copy link
Member

@okJiang okJiang commented May 26, 2025

What problem does this PR solve?

Issue Number: Ref #9351

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

None.

@okJiang
upgrade etcd to 3.5.20
1a79345 
Signed-off-by: okJiang <819421878@qq.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 26, 2025
@okJiang
update
40f7401 
Signed-off-by: okJiang <819421878@qq.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 26, 2025
@okJiang
Copy link
Member Author

okJiang commented May 26, 2025

/retest

1 similar comment
@okJiang
Copy link
Member Author

okJiang commented May 26, 2025

/retest

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 27, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 27, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-05-27 03:19:21.910061439 +0000 UTC m=+325492.281848888: ☑️ agreed by lhy1024.

@ti-chi-bot ti-chi-bot bot added the approved label May 27, 2025
@okJiang
Copy link
Member Author

okJiang commented May 27, 2025

/retest

1 similar comment
@okJiang
Copy link
Member Author

okJiang commented May 27, 2025

/retest

rleungx
rleungx reviewed May 27, 2025
View reviewed changes
go.mod Outdated
go.etcd.io/etcd/client/pkg/v3 v3.5.15
go.etcd.io/etcd/client/v3 v3.5.15
go.etcd.io/etcd/server/v3 v3.5.15
go.etcd.io/etcd/api/v3 v3.5.20
Copy link
Member

@rleungx rleungx May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it mean we should upgrade PD to this version first? So we need to wait for at least one release version, then we can upgrade to v3.6?

Copy link
Member Author

@okJiang okJiang May 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Maybe we should wait a LTS version 🤔

@okJiang
Copy link
Member Author

okJiang commented May 28, 2025

/retest

@okJiang
Copy link
Member Author

okJiang commented May 28, 2025 •
edited
Loading

The ci failed because timeout during running regionTestSuite(exceed 5min).

I think it is because this commit added a wg.Wait() inside etcd.Stop(). So it need to consume more time(10+s for each test case) to exit etcd server.

Maybe we have some operation that caused this. I don't find the reason yet.

@okJiang
update to 3.6.0
55f00f6 
Signed-off-by: okJiang <819421878@qq.com>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 18, 2025
@okJiang
update more
52b4015 
Signed-off-by: okJiang <819421878@qq.com>
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 18, 2025
@okJiang
fix
c317ffb 
Signed-off-by: okJiang <819421878@qq.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lhy1024
Once this PR has been reviewed and has the lgtm label, please assign benmeadowcroft for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the approved label Jun 18, 2025
okJiang added 3 commits July 22, 2025 16:55
@okJiang
Merge branch 'master' of https://github.com/tikv/pd into upgrade-etcd…
c52f0b9 
…3.5.20

Signed-off-by: okjiang <819421878@qq.com>
@okJiang
fix lint
cef2247 
Signed-off-by: okjiang <819421878@qq.com>
@okJiang
Merge branch 'master' of https://github.com/tikv/pd into upgrade-etcd…
80547b0 
…3.5.20

Signed-off-by: okjiang <819421878@qq.com>
@okJiang
fix lint
aa8f685 
Signed-off-by: okjiang <819421878@qq.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 4, 2025

@okJiang: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-unit-test-next-gen-2 aa8f685 link true /test pull-unit-test-next-gen-2
pull-unit-test-next-gen-1 aa8f685 link true /test pull-unit-test-next-gen-1
pull-unit-test-next-gen-3 aa8f685 link true /test pull-unit-test-next-gen-3

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@okJiang
Copy link
Member Author

okJiang commented Mar 15, 2026

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rleungx rleungx rleungx left review comments

@lhy1024 lhy1024 lhy1024 approved these changes

Assignees

No one assigned

Labels

dco-signoff: yes Indicates the PR's author has signed the dco. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@okJiang @lhy1024 @rleungx