Skip to content

support return a specified resource group when get resource group error #9397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

ystaticy
Copy link
Contributor

@ystaticy ystaticy commented Jun 10, 2025

What problem does this PR solve?

Issue Number: ref #9406

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

support return a specified resource group when get resource group error

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. labels Jun 10, 2025
Copy link
Contributor

ti-chi-bot bot commented Jun 10, 2025

Hi @ystaticy. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 10, 2025
Signed-off-by: ystaticy <[email protected]>
@ystaticy ystaticy changed the title support return temp resource group when get resource group error support return a specified resource group when get resource group error Jun 12, 2025
Signed-off-by: ystaticy <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 12, 2025
ystaticy added 2 commits June 12, 2025 14:21
Signed-off-by: ystaticy <[email protected]>
Signed-off-by: ystaticy <[email protected]>
Copy link

codecov bot commented Jun 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.18%. Comparing base (51c2a4d) to head (9e3dc00).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9397      +/-   ##
==========================================
+ Coverage   76.13%   76.18%   +0.05%     
==========================================
  Files         478      478              
  Lines       74586    74756     +170     
==========================================
+ Hits        56785    56954     +169     
- Misses      14272    14274       +2     
+ Partials     3529     3528       -1     
Flag Coverage Δ
unittests 76.18% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ystaticy added 5 commits June 12, 2025 15:47
Signed-off-by: ystaticy <[email protected]>
Signed-off-by: ystaticy <[email protected]>
Signed-off-by: ystaticy <[email protected]>
Signed-off-by: ystaticy <[email protected]>
Signed-off-by: ystaticy <[email protected]>
ystaticy added 2 commits June 12, 2025 19:54
Signed-off-by: ystaticy <[email protected]>
Signed-off-by: ystaticy <[email protected]>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 12, 2025
Copy link
Contributor

ti-chi-bot bot commented Jun 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: disksing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

ti-chi-bot bot commented Jun 12, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-12 12:33:54.495188217 +0000 UTC m=+531212.723503467: ☑️ agreed by disksing.

@ti-chi-bot ti-chi-bot bot added the approved label Jun 12, 2025
@disksing
Copy link
Contributor

@rleungx PTAL

@ti-chi-bot ti-chi-bot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 13, 2025
@ti-chi-bot ti-chi-bot bot removed do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Jun 13, 2025
@ystaticy
Copy link
Contributor Author

/test

Copy link
Contributor

ti-chi-bot bot commented Jun 13, 2025

@ystaticy: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rleungx
Copy link
Member

rleungx commented Jun 13, 2025

/retest

@rleungx
Copy link
Member

rleungx commented Jun 13, 2025

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Jun 13, 2025
@rleungx
Copy link
Member

rleungx commented Jun 13, 2025

/cc @JmPotato @glorv

@ti-chi-bot ti-chi-bot bot requested a review from JmPotato June 13, 2025 03:27
Copy link
Contributor

ti-chi-bot bot commented Jun 13, 2025

@rleungx: GitHub didn't allow me to request PR reviews from the following users: glorv.

Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @JmPotato @glorv

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants