-
Notifications
You must be signed in to change notification settings - Fork 735
support return a specified resource group when get resource group error #9397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: ystaticy <[email protected]>
Hi @ystaticy. Thanks for your PR. I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: ystaticy <[email protected]>
Signed-off-by: ystaticy <[email protected]>
Signed-off-by: ystaticy <[email protected]>
Signed-off-by: ystaticy <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9397 +/- ##
==========================================
+ Coverage 76.13% 76.18% +0.05%
==========================================
Files 478 478
Lines 74586 74756 +170
==========================================
+ Hits 56785 56954 +169
- Misses 14272 14274 +2
+ Partials 3529 3528 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Signed-off-by: ystaticy <[email protected]>
Signed-off-by: ystaticy <[email protected]>
Signed-off-by: ystaticy <[email protected]>
Signed-off-by: ystaticy <[email protected]>
Signed-off-by: ystaticy <[email protected]>
Signed-off-by: ystaticy <[email protected]>
Signed-off-by: ystaticy <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: disksing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
@rleungx PTAL |
/test |
@ystaticy: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
/ok-to-test |
@rleungx: GitHub didn't allow me to request PR reviews from the following users: glorv. Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What problem does this PR solve?
Issue Number: ref #9406
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tiup
:Release note