keyspace: set GCManagementType default value to KeyspaceLevelGC for NextGen

pkg/keyspace/keyspace.go

@@ -39,6 +39,7 @@ import (
 	"github.com/tikv/pd/pkg/utils/keypath"
 	"github.com/tikv/pd/pkg/utils/logutil"
 	"github.com/tikv/pd/pkg/utils/syncutil"
+	"github.com/tikv/pd/pkg/versioninfo/kerneltype"
 )
 
 const (
@@ -233,6 +234,12 @@ func (manager *Manager) CreateKeyspace(request *CreateKeyspaceRequest) (*keyspac
 			request.Config[UserKindKey] = config[UserKindKey]
 		}
 	}
+	// Set default value of GCManagementType to KeyspaceLevelGC for NextGen
+	if kerneltype.IsNextGen() {
+		if v, ok := request.Config[GCManagementType]; !ok || len(v) == 0 {
+			request.Config[GCManagementType] = KeyspaceLevelGC
+		}
+	}
 	// Create a disabled keyspace meta for tikv-server to get the config on keyspace split.
 	keyspace := &keyspacepb.KeyspaceMeta{
 		Id:             newID,

pkg/keyspace/keyspace_test.go

@@ -149,6 +149,48 @@ func (suite *keyspaceTestSuite) TestCreateKeyspace() {
 	re.Error(err)
 }
 
+func (suite *keyspaceTestSuite) TestGCManagementTypeDefaultValue() {
+	re := suite.Require()
+	manager := suite.manager
+
+	now := time.Now().Unix()
+	const classic = `return(false)`
+	const nextGen = `return(true)`
+
+	type testCase struct {
+		nextGenFlag      string
+		gcManagementType string
+		expect           string
+	}
+
+	cases := []testCase{
+		{classic, "", ""},
+		{classic, UnifiedGC, UnifiedGC},
+		{classic, KeyspaceLevelGC, KeyspaceLevelGC},
+		{nextGen, "", KeyspaceLevelGC},
+		{nextGen, UnifiedGC, UnifiedGC},
+		{classic, KeyspaceLevelGC, KeyspaceLevelGC},
+	}
+	defer failpoint.Disable("github.com/tikv/pd/pkg/versioninfo/kerneltype/mockNextGenBuildFlag")
+	for idx, tc := range cases {
+		failpoint.Enable("github.com/tikv/pd/pkg/versioninfo/kerneltype/mockNextGenBuildFlag", tc.nextGenFlag)
+		cfg := make(map[string]string)
+		if tc.gcManagementType != "" {
+			cfg[GCManagementType] = tc.gcManagementType
+		}
+		req := &CreateKeyspaceRequest{
+			Name:       fmt.Sprintf("test_gc_management_type_%d", idx),
+			CreateTime: now,
+			Config:     cfg,
+		}
+		created, err := manager.CreateKeyspace(req)
+		re.NoError(err)
+		loaded, err := manager.LoadKeyspaceByID(created.Id)
+		re.NoError(err)
+		re.Equal(tc.expect, loaded.Config[GCManagementType])
+	}
+}
+
 func makeCreateKeyspaceByIDRequests(count int) []*CreateKeyspaceByIDRequest {
 	now := time.Now().Unix()
 	requests := make([]*CreateKeyspaceByIDRequest, count)

pkg/versioninfo/kerneltype/classic.go

@@ -16,12 +16,21 @@
 
 package kerneltype
 
+import (
+	"github.com/pingcap/failpoint"
+)
+
 var (
 	// KernelType is the current kernel type, which is Classic in this case.
 	KernelType = "Classic"
 )
 
 // IsNextGen returns true if the current kernel type is NextGen.
 func IsNextGen() bool {
+	failpoint.Inject("mockNextGenBuildFlag", func(val failpoint.Value) {
+		if v, ok := val.(bool); ok {
+			failpoint.Return(v)
+		}
+	})
 	return false
 }

pkg/versioninfo/kerneltype/nextgen.go

@@ -16,6 +16,10 @@
 
 package kerneltype
 
+import (
+	"github.com/pingcap/failpoint"
+)
+
 var (
 	// KernelType is the current kernel type, which is Next Generation in this case.
 	KernelType = "Next Generation"
@@ -24,5 +28,10 @@ var (
 // IsNextGen returns true if the current kernel type is Next Generation.
 // see doc.go for more info.
 func IsNextGen() bool {
+	failpoint.Inject("mockNextGenBuildFlag", func(val failpoint.Value) {
+		if v, ok := val.(bool); ok {
+			failpoint.Return(v)
+		}
+	})
 	return true
 }