Skip to content

schedule: fix rule checker is not expected #9439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2025
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jun 24, 2025

What problem does this PR solve?

Issue Number: Close #9440

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue labels Jun 24, 2025
Copy link

codecov bot commented Jun 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.23%. Comparing base (c546b9c) to head (26b6a53).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9439      +/-   ##
==========================================
+ Coverage   76.18%   76.23%   +0.05%     
==========================================
  Files         481      481              
  Lines       75517    75524       +7     
==========================================
+ Hits        57534    57578      +44     
+ Misses      14419    14376      -43     
- Partials     3564     3570       +6     
Flag Coverage Δ
unittests 76.23% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rleungx rleungx changed the title schedule: fix placement rule is not expected schedule: fix rule checker is not expected Jun 24, 2025
@rleungx rleungx requested review from JmPotato and nolouch June 25, 2025 03:15
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 26, 2025
Copy link
Contributor

ti-chi-bot bot commented Jun 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bufferflies, JmPotato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JmPotato,bufferflies]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 30, 2025
Copy link
Contributor

ti-chi-bot bot commented Jun 30, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-26 08:52:29.093801512 +0000 UTC m=+953001.816980487: ☑️ agreed by JmPotato.
  • 2025-06-30 06:28:06.601272553 +0000 UTC m=+1289939.324451533: ☑️ agreed by bufferflies.

@rleungx
Copy link
Member Author

rleungx commented Jun 30, 2025

/retest

@ti-chi-bot ti-chi-bot bot merged commit 4f5e6c0 into tikv:master Jul 1, 2025
56 of 59 checks passed
@rleungx rleungx deleted the rule branch July 1, 2025 05:15
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Jul 7, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #9489.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule checker is not expected
4 participants