Skip to content

resource group: use inner keyspace id rather outside #9475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 3, 2025

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Jul 2, 2025

What problem does this PR solve?

Issue Number: ref #9296

What is changed and how does it work?

use inner keyspace id rather outside to avoid tidb forget pass keyspace id when putResourceGroup

Check List

Tests

  • Unit test
  • Manual test
File: tidb.toml
keyspace-name = "SYSTEM"
File: tikv.toml
[storage]
enable-ttl = true
api-version = 2
cd ~/tidb
NEXT_GEN=1 make server
cd ~/pd
NEXT_GEN=1 make pd-server
tiup playground nightly --kv 3 --tiflash 0 --host 0.0.0.0 --db.binpath=~/tidb/bin/tidb-server --pd.binpath=~/pd/bin/pd-server --db.config=~/tidb.toml --kv.config=~/tikv.toml
cd tests/integrationtest;                                                                                                                       ~/tidb
./mysql_tester -port 4000 --check-error=true --collation-disable=false --record ddl/resource_group
./t/ddl/resource_group.test: ok! 16 test cases passed, take time 1.441095362 s

Great, All tests passed

Release note

None.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 2, 2025
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 3, 2025
Signed-off-by: lhy1024 <[email protected]>
Signed-off-by: lhy1024 <[email protected]>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 3, 2025
Copy link
Contributor

ti-chi-bot bot commented Jul 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 3, 2025
Copy link
Contributor

ti-chi-bot bot commented Jul 3, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-07-03 06:32:24.852821739 +0000 UTC m=+1549397.576000721: ☑️ agreed by rleungx.
  • 2025-07-03 08:36:04.977707253 +0000 UTC m=+1556817.700886232: ☑️ agreed by okJiang.

Copy link

codecov bot commented Jul 3, 2025

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.18%. Comparing base (b88e47d) to head (1d3791b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9475      +/-   ##
==========================================
- Coverage   76.20%   76.18%   -0.02%     
==========================================
  Files         481      481              
  Lines       75538    75551      +13     
==========================================
- Hits        57560    57559       -1     
- Misses      14405    14421      +16     
+ Partials     3573     3571       -2     
Flag Coverage Δ
unittests 76.18% <95.45%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot bot merged commit dfd345b into tikv:master Jul 3, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants