Use spin-rs to replace parking lot to avoid deadlock
#268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yang Keao <[email protected]>
YangKeao
force-pushed
the
use-spin-to-replace-parking-lot
branch
from
1c7f274 to
29b284f
Compare
LykxSassinator
approved these changes
May 22, 2025
YangKeao
added a commit
that referenced
this pull request
Jul 23, 2025
Signed-off-by: Yang Keao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref tikv/tikv#18474, #29
The parking lot is not actually a spinlock. And the
spin-rsis still actively maintained 🍻 . We should usespin-rsinstead!