Using File System "Punch Hole" API for GC #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yang Zhang <[email protected]>
Signed-off-by: v01dstar <[email protected]>
Signed-off-by: v01dstar <[email protected]>
|
@v01dstar Please add design doc PR for this large change. |
Signed-off-by: tonyxuqqi <[email protected]>
Signed-off-by: tonyxuqqi <[email protected]>
Signed-off-by: tonyxuqqi <[email protected]>
Signed-off-by: tonyxuqqi <[email protected]>
Signed-off-by: Yang Zhang <[email protected]>
Signed-off-by: Yang Zhang <[email protected]>
Signed-off-by: Yang Zhang <[email protected]>
Signed-off-by: Yang Zhang <[email protected]>
Signed-off-by: Yang Zhang <[email protected]>
Signed-off-by: Yang Zhang <[email protected]>
Signed-off-by: v01dstar <[email protected]>
Signed-off-by: v01dstar <[email protected]>
Signed-off-by: v01dstar <[email protected]>
Signed-off-by: v01dstar <[email protected]>
Signed-off-by: v01dstar <[email protected]>
Signed-off-by: v01dstar <[email protected]>
Signed-off-by: v01dstar <[email protected]>
v01dstar
force-pushed
the
gc-punch-hole
branch
2 times, most recently
from
64929a4
to
ef34a73
Compare
Signed-off-by: v01dstar <[email protected]>
Signed-off-by: v01dstar <[email protected]>
Signed-off-by: v01dstar <[email protected]>
Connor1996
reviewed
May 22, 2024
| @@ -232,13 +234,11 @@ void TitanTableBuilder::FinishBlobFile() { | |||
| AddBlobResultsToBase(contexts); | |||
|
|
|||
| if (s.ok() && ok()) { | |||
| TITAN_LOG_INFO(db_options_.info_log, | |||
Connor1996
reviewed
May 22, 2024
| @@ -201,6 +201,8 @@ class TitanDB : public StackableDB { | |||
| // "rocksdb.titandb.discardable_ratio_le100_file_num" - returns count of | |||
| // file whose discardable ratio is less or equal to 100%. | |||
| static const std::string kNumDiscardableRatioLE100File; | |||
|
|
|||
| static const std::string kNumHolePunchableBlocks; | |||
Connor1996
reviewed
May 23, 2024
| @@ -319,7 +440,38 @@ Status TitanDBImpl::TEST_StartGC(uint32_t column_family_id) { | |||
| bg_gc_running_++; | |||
| bg_gc_scheduled_++; | |||
|
|
|||
| s = BackgroundGC(&log_buffer, column_family_id); | |||
There was a problem hiding this comment.
why don't reuse BackgroundGC anymore?
| LogFlush(db_options_.info_log.get()); | ||
| mutex_.Lock(); | ||
| bool run_punch_hole_gc = false; | ||
| if (scheduled_punch_hole_gc_ != nullptr && !punch_hole_gc_running_) { |
There was a problem hiding this comment.
Can we separate the punch hole code path with the normal GC for brevity?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.