simplify the implement of mark_sleep and mark_woken #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: glorv <[email protected]>
sticnarf
approved these changes
Aug 16, 2022
| @@ -103,38 +103,22 @@ impl<T> QueueCore<T> { | |||
| /// | |||
| /// It can be marked as sleep only when the pool is not shutting down. | |||
| pub fn mark_sleep(&self) -> bool { | |||
| let mut cnt = self.active_workers.load(Ordering::SeqCst); | |||
| loop { | |||
| if is_shutdown(cnt) { | |||
There was a problem hiding this comment.
Yep, the active count should be not important once the pool is shut down.
@BusyJay Is there any special reason to check shutdown first?
There was a problem hiding this comment.
No. Combining a loop and compare_exchange_weak just to be more performant when there is something to check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.