Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements improvements to List components, focusing on color prop propagation, layout adjustments, and code cleanup. The changes enable proper background color handling throughout the list component hierarchy and make layout adjustments to list spacing and headers.
Changes:
- Added color prop support to List components (EmptyContent, ListGroup, ScrollView) for proper background color propagation
- Adjusted list header height from 45 to 24 and introduced
listSpacerHeighttoken - Removed outdated comments and refactored list wrapper logic for empty/loading states
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/config/tamagui.config.ts | Updated list header height, refactored betweenLists token into a constant, and added listSpacerHeight |
| src/components/ScrollView/ScrollView.tsx | Added color prop support and backgroundColor mapping |
| src/components/List/Wrapper/index.tsx | Refactored empty/loading state rendering and added color prop propagation |
| src/components/List/Simple/stories.tsx | Added new story with color prop, fixed typo in empty content text |
| src/components/List/Simple/index.tsx | Wrapped list content in fragment with biome-ignore comment |
| src/components/List/Group/index.tsx | Commented out isFullWidth prop, added console.log debug statement, added contentContainerStyle |
| src/components/List/EmptyContent.tsx | Added color prop support and reformatted code |
Comments suppressed due to low confidence (1)
src/components/ScrollView/ScrollView.tsx:34
- The color prop is not applied when alwaysBounceVertical is false. The else branch should also pass backgroundColor={color} to maintain consistent behavior.
return <TGScrollView {...props} />
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| export * from "./components/ListItem" | ||
| export * from "./components/ParadigmProvider" | ||
| export * from "./components/ScrollView" | ||
| export * from "./components/SettingsList" |
There was a problem hiding this comment.
🚫 [tsc] <2307> reported by reviewdog 🐶
Cannot find module './components/SettingsList' or its corresponding type declarations.
| "onlyChanged": true, | ||
| "projectId": "Project:62fea75bb5d432cf221355c3", | ||
| "zip": true |
There was a problem hiding this comment.
[Biome] reported by reviewdog 🐶
| "onlyChanged": true, | |
| "projectId": "Project:62fea75bb5d432cf221355c3", | |
| "zip": true | |
| "onlyChanged": true, | |
| "projectId": "Project:62fea75bb5d432cf221355c3", | |
| "zip": true |
| @@ -0,0 +1,14 @@ | |||
| import preview from "@/storybook/preview" | |||
| import { SettingsList } from "./index" | |||
There was a problem hiding this comment.
🚫 [tsc] <2307> reported by reviewdog 🐶
Cannot find module './index' or its corresponding type declarations.
No description provided.