-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds branch command to unset upstream #1944
Conversation
4d597df
to
449f6d0
Compare
Ah, that's useful. We actually have a command in the Command Palette to unset the tracking information for the checked out branch, that is GitSavvy/core/commands/branch.py Lines 145 to 154 in 5aa2dfa
Let's just delegate to that command. We do this quite often in this interface. Something among GitSavvy/core/interfaces/branch.py Lines 481 to 485 in ca8605a
and if it actually has upstream/tracking set. |
449f6d0
to
70aaeb1
Compare
70aaeb1
to
bf90604
Compare
Thanks @kaste. I think I've implemented all of those changes. I couldn't find any docs or relevant tests but happy to if I've missed something. |
Excellent. I usually don't have tests for these ... basically simple wrappers. Most logic is in the parent classes e.g. Actually, happy that this is such a simple diff/patch as well. (I still need to fix these mypy errors; the latest mypy version got smarter and I did not pin the version here. 😬) Let's roll. |
🥁 |
many thanks for maintaining the plugin @kaste! Not sure how much time I save with it weekly. All muscle memory now. How long does package control take to pickup the new version? |
It's a crawler... checks every 3 hours |
No description provided.