Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make database connection string clearer #3565

Open
wants to merge 3 commits into
base: latest
Choose a base branch
from
Open

Make database connection string clearer #3565

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f70be0
Make database connection string clearer
bytrangle Nov 8, 2024
8a83c1a
Merge branch 'latest' into patch-1
bytrangle Nov 8, 2024
8a1f5ab
Merge branch 'latest' into patch-1
billy-the-fish Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions quick-start/node.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,15 +108,15 @@ ORM (object relational mapper) called [Sequelize][sequelize-info].
1. Compose your connection string variable, using this format:

```java
'postgres://user:pass@example.com:5432/dbname'
'postgres://<user>:<pass>@<host>:<port>/<dbname>'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'postgres://<user>:<pass>@<host>:<port>/<dbname>'
'postgres://<user>:<password>@<host>:<port>/<dbname>'

```

1. Open the `index.js` file you created. Require Sequelize in the application,
and declare the connection string:

```java
const Sequelize = require('sequelize')
const sequelize = new Sequelize('postgres://user:pass@example.com:5432/dbname',
const sequelize = new Sequelize('postgres://<user>:<pass>@<host>:<port>/<dbname>',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const sequelize = new Sequelize('postgres://<user>:<pass>@<host>:<port>/<dbname>',
const sequelize = new Sequelize('postgres://<user>:<password>@<host>:<port>/<dbname>',

{
dialect: 'postgres',
protocol: 'postgres',
Expand Down