Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve quickstart #374

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: Improve quickstart #374

wants to merge 1 commit into from

Conversation

cevian
Copy link
Collaborator

@cevian cevian commented Jan 17, 2025

No description provided.

@cevian cevian requested a review from a team as a code owner January 17, 2025 20:53
Copy link
Member

@JamesGuthrie JamesGuthrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor nits.


- Automatic creation and synchronization of vector embeddings for your data
- Seamless vector and semantic search
- Retrieval Augmented Generation(RAG) directly in SQL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Retrieval Augmented Generation(RAG) directly in SQL
- Retrieval Augmented Generation (RAG) directly in SQL

@@ -125,7 +134,9 @@ This section will walk you through the steps to get started with pgai and Ollama

1. **Search the embeddings**

We'll search the embeddings for the concept of "properties of light"
We'll search the embeddings for the concept of "properties of light" even though these words are not in the text of the articles. This is only possible because of vector embeddings that capture the semantic meaning of the text.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
We'll search the embeddings for the concept of "properties of light" even though these words are not in the text of the articles. This is only possible because of vector embeddings that capture the semantic meaning of the text.
We'll search the embeddings for the concept of "properties of light" even though these words are not in the text of the articles. This is possible because vector embeddings capture the semantic meaning of the text.

```
And now you don't need to do anything to update the embeddings. The vectorizer will automatically create the embeddings for the new row with any intervention from you. After a few seconds, you can run the search query again to see the new embedding.
And now you don't need to do anything to update the embeddings. The vectorizer will automatically create the embeddings for the new row with any intervention from you. After a few seconds, you can run the following search query to see the new embedding:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
And now you don't need to do anything to update the embeddings. The vectorizer will automatically create the embeddings for the new row with any intervention from you. After a few seconds, you can run the following search query to see the new embedding:
And now you don't need to do anything to update the embeddings. The vectorizer will automatically create the embeddings for the new row without any intervention from you. After a few seconds, you can run the following search query to see the new embedding:

@cevian cevian requested a review from solugebefola January 21, 2025 19:13
Copy link

@solugebefola solugebefola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

  • I think we need to add somewhere early, what the auto-generated (in this case wiki_embeddings) view does. I don't know that it's something that's exactly analogous to other vector databases? I know other DBs store metadata along with chunks, but it might be nice to clarify early on what most of the queries are running against, e.g. most of the semantic search and RAG queries are against the wiki_embeddings view.

```sql
SELECT title, chunk
FROM wiki_embeddings
ORDER BY embedding <=> ai.ollama_embed('all-minilm', 'AI tools')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a SQL comment here to explain how this translates to seeing the latest embedding?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants