feat: add ai.anthropic_list_models #386
Merged
+73
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasterOdin
commented
Jan 23, 2025
| @@ -16,3 +17,13 @@ def make_client( | |||
| if max_retries is not None: | |||
| args["max_retries"] = max_retries | |||
| return Anthropic(api_key=api_key, base_url=base_url, **args) | |||
|
|
|||
|
|
|||
| def list_models( | |||
There was a problem hiding this comment.
Wasn't sure if it'd be better to have this python function that gets called (similar to openai) or have it be inline in the sql file (similar to ollama). 🤷
I think the nice thing is maybe that python tooling is a bit more universal for python files vs embedded python in SQL files.
There was a problem hiding this comment.
I think the nice thing is maybe that python tooling is a bit more universal for python files vs embedded python in SQL files.
Yeah, I think so too. This is fine IMO.
MasterOdin
force-pushed
the
mpeveler/feat-anthropic-list-models
branch
2 times, most recently
from
221aa69 to
088ba55
Compare
Signed-off-by: Matthew Peveler <[email protected]>
MasterOdin
force-pushed
the
mpeveler/feat-anthropic-list-models
branch
from
088ba55 to
1938e5a
Compare
jgpruitt
requested changes
Jan 23, 2025
MasterOdin
force-pushed
the
mpeveler/feat-anthropic-list-models
branch
from
a5efff0 to
84d0b42
Compare
Co-authored-by: John Pruitt <[email protected]> Signed-off-by: Matthew Peveler <[email protected]>
MasterOdin
force-pushed
the
mpeveler/feat-anthropic-list-models
branch
from
84d0b42 to
aa43c92
Compare
jgpruitt
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR implements the
ai.anthropic_list_modelsfunction, which currently returns columns(id, name, created)which gives: