Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

includes tds_fdw libraries #295

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

includes tds_fdw libraries #295

wants to merge 1 commit into from

Conversation

fagner-icarotech
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Aug 10, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@fagner-icarotech
Copy link
Author

includes tds_fdw libraries

feikesteenbergen
feikesteenbergen requested changes Aug 19, 2022
View reviewed changes
Copy link
Member

@feikesteenbergen feikesteenbergen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion of adding this. What benefit does it bring?
What are the costs of this feature:

  • increase in image size
  • increase in build times?

Dockerfile
@@ -98,7 +98,7 @@ RUN set -eux; \
RUN apt-get update && apt-get install -y dumb-init daemontools

RUN apt-get update \
&& apt-get install -y postgresql-common pgbouncer pgbackrest lz4 libpq-dev libpq5 pgtop \
&& apt-get install -y postgresql-common pgbouncer pgbackrest lz4 libpq-dev libpq5 pgtop libsybdb5 freetds-dev freetds-common gnupg gcc make \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding gnupg gcc make and all the others on this line isn't great.

On line 114 make, gmake, gcc and gpg are already installed, adding a separte RUN command after that line that would would IMHO be preferable over this. Somewhere after lines 127 seems more appropriate, because at that point many postgresql packages are already installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feikesteenbergen feikesteenbergen feikesteenbergen requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fagner-icarotech @CLAassistant @feikesteenbergen