Update rspec syntax so skipable test does not execute.#131
Open
rapito wants to merge 1 commit intotimescale:masterfrom
Open
Update rspec syntax so skipable test does not execute.#131rapito wants to merge 1 commit intotimescale:masterfrom
rapito wants to merge 1 commit intotimescale:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer
I'm sorry for the spams of PRs, just trying to make the changes separate in case you don't need one of them.
Description
This is just something that was bothering me when running tests for the other PR.
Basically there was one test that was being skipped with a method that does not prevent before, after, around hooks to be executed and also causes visual noise on the logs.
Here's the output before the update:
Here's after:
The change is simply using the skip at the declaration level of the example/spec instead of inside it's implementation.