Backport to 2.18.x: #7797: Fix cleanup of compression settings with drop cascade #7805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a table was dropped with the "cascade" option, compression settings weren't properly cleaned up as a result of refactoring in commit adf7c39. It seems dropping with the "cascade" option invokes a different path for dropping the hypertable and children chunks, and there was no test for it. A test has now been added. (cherry picked from commit 76770f6)
timescale-automation
added
the
is-auto-backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated backport of #7797: Fix cleanup of compression settings with drop cascade.
This PR will be merged automatically after all the relevant CI checks pass. If this fix should not be backported, or will be backported manually, just close this PR. You can use the backport branch to add your changes, it won't be modified automatically anymore.
For more details, please see the documentation
Original description
Fix cleanup of compression settings with drop cascade
When a table was dropped with the "cascade" option, compression settings weren't properly cleaned up as a result of refactoring in commit adf7c39. It seems dropping with the "cascade" option invokes a different path for dropping the hypertable and children chunks, and there was no test for it. A test has now been added.
Disable-check: force-changelog-file