Implemented SimpleProgress suitable for output to file#222
Open
jagot wants to merge 1 commit intotimholy:masterfrom
Open
Implemented SimpleProgress suitable for output to file#222jagot wants to merge 1 commit intotimholy:masterfrom
jagot wants to merge 1 commit intotimholy:masterfrom
Conversation
Collaborator
|
Could this be done by adding an option in the constructor of the Progressbars or in |
Author
|
I guess, but |
Collaborator
|
I believe it's more versatile to add this as an option (what if someone wants this but with colors, or with a I made a draft of what it could look like (#223) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running on e.g. a cluster, the output is usually redirected to a
file, where the escape characters turn into a jumbled mess (see
#151). This PR implements a simple swap-in for
Progressthat insteadprints a new line after each progress update:
which gives output like this:
showvalues&showspeedis also supported:This PR does not implement
finish!orcancel.Is this interesting? Are the tests adequate?