print progressbar also for n=1 and n=2#261
Open
CarloLucibello wants to merge 2 commits intotimholy:masterfrom
Open
print progressbar also for n=1 and n=2#261CarloLucibello wants to merge 2 commits intotimholy:masterfrom
CarloLucibello wants to merge 2 commits intotimholy:masterfrom
Conversation
CarloLucibello
commented
Mar 7, 2023
|
|
||
| if p.counter >= p.n | ||
| if p.counter == p.n && p.printed | ||
| if p.counter == p.n #&& p.printed |
Author
There was a problem hiding this comment.
@timholy I'm not sure about the effect of this. What's the purpose of p.printed?
Owner
There was a problem hiding this comment.
It's part of ensuring you don't start printing only at finish: you have to print at least one update for this block to print anything at all.
Author
|
@timholy could you take a look? I run the tests locally and they seem fine by visual inspection |
Owner
|
The default behavior of not printing needs to be retained; users should opt-in if they want it to print. To make this customizable you'd probably have to add another field to |
Owner
|
Oh, I'd forgotten #258 (comment), sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #258