-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default spinner collection #282
Draft
alicedb2
wants to merge
12
commits into
timholy:master
Choose a base branch
from
alicedb2:spinner_collection
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #282 +/- ##
==========================================
- Coverage 96.81% 90.12% -6.69%
==========================================
Files 1 2 +1
Lines 533 567 +34
==========================================
- Hits 516 511 -5
- Misses 17 56 +39 ☔ View full report in Codecov by Sentry. |
…len string spinners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like spinners with my
ProgressUnknown()
, so here's a collection of 110 of them. The first 89 are stolen (with credits) from https://github.com/briandowns/spinner, the rest (90-110) I had fun creating last evening.Summary of the changes (see below for a demo):
spinnercollection
of 110 spinners,AbstractVector{<:AbstractString}
. Were there any reason to restrict them to a singleChar
?next!(prog, spinner=idx)
is equivalent tonext!(prog, spinner=spinnercollection[idx])
demospinners()
function that shows them all in action, but alsodemospinners(idx)
to look at a specific spinner in the collection,demospinners(string)
,demospinners(vector_of_chars)
, anddemospinners(vector_of_strings)
to look at your own custom spinner,demospinners(vector_of_vectors_of_strings)
to look at your own set of custom spinners in a nicely aligned table.demospinners()
is justdemospinners(spinnercollection)
.I don't know if anyone is interested, but if so then I'm looking for input on how to make the code align better with the organiziation/idioms of ProgressMeter.jl. Maybe we could also shrink the collection a bit and be more selective about which spinners to include.
Demo (the gif doesn't loop perfectly like the spinners in the demo do for obvious reasons, the LCM of all spinner lengths is 27,003,936,960):
and so you can get things like this