Skip to content

Conversation

@xgdgsc
Copy link

@xgdgsc xgdgsc commented Feb 23, 2025

I find the defaultglyphs printed inline in VSCode too long and weird.

@codecov
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 95.07%. Comparing base (807496a) to head (46bf0fa).
Report is 22 commits behind head on master.

Files with missing lines Patch % Lines
src/ProgressMeter.jl 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #337      +/-   ##
==========================================
+ Coverage   93.48%   95.07%   +1.59%     
==========================================
  Files           1        1              
  Lines         399      569     +170     
==========================================
+ Hits          373      541     +168     
- Misses         26       28       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcMush
Copy link
Collaborator

MarcMush commented Mar 2, 2025

from https://docs.julialang.org/en/v1/manual/types/#man-custom-pretty-printing:

As a rule of thumb, the single-line show method should print a valid Julia expression for creating the shown object.

so we should print every non-default parameter I guess, nearly all of them can be changed

it should also include ProgressUnknown and ProgressThresh

otherwise, I believe you can just add a semi colon at the end of the line to hide the output

@xgdgsc
Copy link
Author

xgdgsc commented Mar 4, 2025

I don' t think a daily utility 99% users would only change or care about the n should follow that rule or see anything inside ProgressCore . I' ve never used ProgressUnknown or ProgressThresh so I wouldn' t change that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants