Add showelapsed and showeta options to Progress#356
Open
lgoettgens wants to merge 1 commit intotimholy:masterfrom
Open
Add showelapsed and showeta options to Progress#356lgoettgens wants to merge 1 commit intotimholy:masterfrom
showelapsed and showeta options to Progress#356lgoettgens wants to merge 1 commit intotimholy:masterfrom
Conversation
Author
|
@timholy would you mind having a look at this? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #287.
This adds the possibility to set
showelapsed=truefor aProgressobject to additionally show the total elapsed time. Withshoweta=false, one can further hide the current eta output.To make this work, I had to refactor
tty_widthquite a bit, but I think the new comments there make it really clear what's happening.I am happy to hear your feedback!