Skip to content

Commit

Permalink
Set tamagui target per platform in dev & CI/CD (was deleted in anothe…
Browse files Browse the repository at this point in the history
…r PR)

Bumped expo version
Added expo tools to vs code extensions
  • Loading branch information
timothymiller committed Jul 25, 2023
1 parent f02a889 commit f57578b
Show file tree
Hide file tree
Showing 7 changed files with 76 additions and 267 deletions.
1 change: 1 addition & 0 deletions .github/workflows/expo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ jobs:
id: build
continue-on-error: true
run: |
export TAMAGUI_TARGET=native
cd apps/expo && build_json=$(eas build --profile $BUILD_PROFILE --platform all --non-interactive --json)
android_link=$(echo $build_json | jq -r '.[] | select(.platform=="ANDROID") | .artifacts.applicationArchiveUrl')
ios_link=$(echo $build_json | jq -r '.[] | select(.platform=="IOS") | .artifacts.applicationArchiveUrl')
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/next.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ jobs:
- name: Build
run: |
cd apps/next
export TAMAGUI_TARGET=web
export NEXT_PUBLIC_API_URL=${{ secrets.NEXT_PUBLIC_API_URL }}
export NEXT_PUBLIC_APP_URL=${{ secrets.NEXT_PUBLIC_APP_URL }}
export NEXT_PUBLIC_SUPABASE_URL=${{ secrets.NEXT_PUBLIC_SUPABASE_URL }}
Expand Down
3 changes: 2 additions & 1 deletion .vscode/extensions.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"wilsonsio.color-vision",
"bungcip.better-toml",
"formulahendry.auto-rename-tag",
"dbaeumer.vscode-eslint"
"dbaeumer.vscode-eslint",
"expo.vscode-expo-tools"
]
}
4 changes: 2 additions & 2 deletions apps/expo/app.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ export default ({ config }: ConfigContext): ExpoConfig => ({
...config,
extra: {
eas: {
projectId: process.env.EAS_PROJECT_ID ?? 'timothymiller',
projectId: process.env.EAS_PROJECT_ID || 'timothymiller',
},
},
owner: process.env.EAS_OWNER ?? '85fc6ccd-0ce1-4e4d-804c-b15df989f97e',
owner: process.env.EAS_OWNER || '85fc6ccd-0ce1-4e4d-804c-b15df989f97e',
plugins: ['expo-router'],
experiments: {
tsconfigPaths: true,
Expand Down
2 changes: 1 addition & 1 deletion apps/expo/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"app": "*",
"babel-plugin-module-resolver": "^4.1.0",
"burnt": "^0.11.7",
"expo": "^49.0.3",
"expo": "^49.0.5",
"expo-constants": "~14.4.2",
"expo-dev-client": "~2.4.6",
"expo-font": "~11.4.0",
Expand Down
6 changes: 3 additions & 3 deletions apps/next/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
"version": "2.0.0",
"private": true,
"scripts": {
"dev": "pnpm with-env next dev",
"build": "pnpm with-env next build",
"start": "pnpm with-env next start",
"dev": "TAMAGUI_TARGET=web pnpm with-env next dev",
"build": "TAMAGUI_TARGET=web pnpm with-env next build",
"start": "TAMAGUI_TARGET=web pnpm with-env next start",
"lint": "next lint",
"with-env": "dotenv -e ../../.env.local --",
"clean": "git clean -xdf .next node_modules .tamagui"
Expand Down
Loading

1 comment on commit f57578b

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔ EAS development build completed

  • 🤖 Android build failed ❌
  • 🍏 IOS build failed ❌
Android QR IOS QR

Please sign in to comment.