Skip to content

Conversation

@adonisfigueroa
Copy link

Options to set the maximun time to wait for the Connection and for get the Response.

@rolftimmermans
Copy link
Contributor

Thanks! We always aim for feature parity across the client libraries (for all languages). If we implement this we also wish to think about how it applies to the other libraries. Would it make sense to you if you could set the timeout and connection timeout with an option?

For example something like:

\Tinify\setRequestTimeout(1234);
\Tinify\setConnectionTimeout(1234);

Copy link
Author

@adonisfigueroa adonisfigueroa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New functions:
setRequestTimeout
setRequestTimeoutMS
setConnectionTimeout
setConnectionTimeoutMS

instead setExtraOptions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants