Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the ability to specify custom location for
grub.cfg
.Why is this needed
Ubuntu 24.04 cloud image mounts the
/boot
partition. The default/boot/grub/grub.cfg
location is invalid when we mount the partition. The location when there is a/boot
partition isgrub/grub.cfg
.Fixes: #142
How Has This Been Tested?
jammy
. NoGRUBCFG_PATH
. I was able to ssh into[email protected]
.noble
. NoGRUBCFG_PATH
. I was NOT able to ssh into[email protected]
. Expected to fail asnoble
uses a/boot
partition.noble
. The value forGRUBCFG_PATH
was set togrub/grub.cfg
. The value forBLOCK_DEVICE
was set to{{ formatPartition ( index .Hardware.Disks 0 ) 16 }}
. I was able to ssh into[email protected]
.How are existing users impacted? What migration steps/scripts do we need?
It uses the default value of
boot/grub/grub.cfg
forGRUBCFG_PATH
if not specified. Existing users are not impacted.Checklist:
I have:
More info on Ubuntu 24.04 cloud image partition - https://bugs.launchpad.net/cloud-images/+bug/2072929