Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CRD update into bmclib client: #258

Merged

Conversation

jacobweinstock
Copy link
Member

Description

The new CRD fields in the redfish provider options were not implemented in the client instantiation.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

The new CRD fields in the redfish provider options
were not implemented in the client instantiation.

Signed-off-by: Jacob Weinstock <[email protected]>
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 47.39%. Comparing base (c5afdbb) to head (31610c1).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
controller/client.go 0.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #258      +/-   ##
==========================================
- Coverage   47.60%   47.39%   -0.22%     
==========================================
  Files          11       11              
  Lines        1338     1344       +6     
==========================================
  Hits          637      637              
- Misses        646      650       +4     
- Partials       55       57       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobweinstock jacobweinstock merged commit 0b6d3cf into tinkerbell:main Oct 23, 2024
5 of 7 checks passed
@jacobweinstock jacobweinstock deleted the implement-bmclib-update branch October 23, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant