Add configurable concurrent reconciliation to controllers #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The controller-runtime defaults MaxConcurrentReconciles to 1, which creates a bottleneck when multiple BMC operations need to be processed simultaneously. This is particularly noticeable during cluster provisioning when many nodes are being set up in parallel. This change adds a CLI flag (--max-concurrent-reconciles) and corresponding environment variable (RUFIO_MAX_CONCURRENT_RECONCILES) to configure the number of concurrent reconciliations across all controllers. Signed-off-by: Rahul Ganesh <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #312 +/- ##
==========================================
- Coverage 47.02% 46.85% -0.18%
==========================================
Files 11 11
Lines 1361 1366 +5
==========================================
Hits 640 640
- Misses 664 669 +5
Partials 57 57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jacobweinstock
approved these changes
Jun 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The controller-runtime defaults MaxConcurrentReconciles to 1, which creates a bottleneck when multiple BMC operations need to be processed simultaneously. This is particularly noticeable during cluster provisioning when many nodes are being set up in parallel.
This change adds a CLI flag (--max-concurrent-reconciles) and corresponding environment variable (RUFIO_MAX_CONCURRENT_RECONCILES) to configure the number of concurrent reconciliations across all controllers.
Why is this needed
Performance testing with 30 nodes showed:
Fixes: #
#311
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: