kickstart esxi: Remove the -s option from wget (#207)

## Description

The VMware installer was previously relying on wget's "-s" or spider option to determine whether or not a particular URL was accessible while handling the customdata portion of the kickstart. This option is not valid on the version of wget which ships with current closed-source ESXi installers.

## Why is this needed

This change fixes a bug related to the customdata logic responsible for executing the kickstart postinstall scripts and kickstart firstboot install scripts provided via customdata.

Fixes: #

## How Has This Been Tested?
CI testing


## How are existing users impacted? What migration steps/scripts do we need?

Fixes customdata bug and unblocks further VMware VCF configuration.


## Checklist:

I have:

- [ ] updated the documentation and/or roadmap (if required)
- [ ] added unit or e2e tests
- [ ] provided instructions on how to upgrade

installers/vmware/kickstart-esxi.go

@@ -231,13 +231,12 @@ fi
 # Kickstart firstboot supplemental config URL
 if [ "$kickstartfburl" != "null" ]; then
 	echo "Using supplemental kickstart firstboot URL: $kickstartfburl"
-	if wget -q -s $kickstartfburl; then
-		wget -q $kickstartfburl -O /tmp/ks-firstboot-sup.sh
+	if wget -q "$kickstartfburl" -O /tmp/ks-firstboot-sup.sh; then
 		echo "========Begin execution of supplemental firstboot kickstart"
 		chmod +x /tmp/ks-firstboot-sup.sh && /tmp/ks-firstboot-sup.sh
 		echo "========End execution of supplemental firstboot kickstart"
 	else
-		echo "ERROR: Custom kickstart firstboot URL is NOT accessible!"
+		echo "ERROR: Custom kickstart firstboot URL '$kickstartfburl' is NOT accessible!"
 		exit 1
 	fi
 else
@@ -308,18 +307,17 @@ kickstartpishellcmd=$(custom_data "['kickstart']['postinstall_shell_cmd']")
 
 # Kickstart postinstall supplemental config URL
 if [ "$kickstartpiurl" != "null" ]; then
-        echo "Using supplemental kickstart postinstall URL: $kickstartpiurl"
-        if wget -q -s $kickstartpiurl; then
-                wget -q $kickstartpiurl -O /tmp/ks-postinstall-sup.sh
-                echo "========Begin execution of supplemental postinstall kickstart"
-                chmod +x /tmp/ks-postinstall-sup.sh && /tmp/ks-postinstall-sup.sh
-                echo "========End execution of supplemental postinstall kickstart"
-        else
-                echo "ERROR: Custom kickstart postinstall URL is NOT accessible!"
-                exit 1
-        fi
+	echo "Using supplemental kickstart postinstall URL: $kickstartpiurl"
+	if wget -q "$kickstartpiurl" -O /tmp/ks-postinstall-sup.sh; then
+		echo "========Begin execution of supplemental postinstall kickstart"
+		chmod +x /tmp/ks-postinstall-sup.sh && /tmp/ks-postinstall-sup.sh
+		echo "========End execution of supplemental postinstall kickstart"
+	else
+		echo "ERROR: Custom kickstart postinstall URL '$kickstartpiurl' is NOT accessible!"
+		exit 1
+	fi
 else
-        echo "Skipping supplemental kickstart postinstall URL"
+	echo "Skipping supplemental kickstart postinstall URL"
 fi
 
 # Kickstart postinstall supplemental shell commands

installers/vmware/testdata/vmware_base.txt

@@ -197,13 +197,12 @@ fi
 # Kickstart firstboot supplemental config URL
 if [ "$kickstartfburl" != "null" ]; then
 	echo "Using supplemental kickstart firstboot URL: $kickstartfburl"
-	if wget -q -s $kickstartfburl; then
-		wget -q $kickstartfburl -O /tmp/ks-firstboot-sup.sh
+	if wget -q "$kickstartfburl" -O /tmp/ks-firstboot-sup.sh; then
 		echo "========Begin execution of supplemental firstboot kickstart"
 		chmod +x /tmp/ks-firstboot-sup.sh && /tmp/ks-firstboot-sup.sh
 		echo "========End execution of supplemental firstboot kickstart"
 	else
-		echo "ERROR: Custom kickstart firstboot URL is NOT accessible!"
+		echo "ERROR: Custom kickstart firstboot URL '$kickstartfburl' is NOT accessible!"
 		exit 1
 	fi
 else
@@ -274,18 +273,17 @@ kickstartpishellcmd=$(custom_data "['kickstart']['postinstall_shell_cmd']")
 
 # Kickstart postinstall supplemental config URL
 if [ "$kickstartpiurl" != "null" ]; then
-        echo "Using supplemental kickstart postinstall URL: $kickstartpiurl"
-        if wget -q -s $kickstartpiurl; then
-                wget -q $kickstartpiurl -O /tmp/ks-postinstall-sup.sh
-                echo "========Begin execution of supplemental postinstall kickstart"
-                chmod +x /tmp/ks-postinstall-sup.sh && /tmp/ks-postinstall-sup.sh
-                echo "========End execution of supplemental postinstall kickstart"
-        else
-                echo "ERROR: Custom kickstart postinstall URL is NOT accessible!"
-                exit 1
-        fi
+	echo "Using supplemental kickstart postinstall URL: $kickstartpiurl"
+	if wget -q "$kickstartpiurl" -O /tmp/ks-postinstall-sup.sh; then
+		echo "========Begin execution of supplemental postinstall kickstart"
+		chmod +x /tmp/ks-postinstall-sup.sh && /tmp/ks-postinstall-sup.sh
+		echo "========End execution of supplemental postinstall kickstart"
+	else
+		echo "ERROR: Custom kickstart postinstall URL '$kickstartpiurl' is NOT accessible!"
+		exit 1
+	fi
 else
-        echo "Skipping supplemental kickstart postinstall URL"
+	echo "Skipping supplemental kickstart postinstall URL"
 fi
 
 # Kickstart postinstall supplemental shell commands