Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add auto capabilities: #946

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jacobweinstock
Copy link
Member

Description

This adds the following auto capabilities:

discover: creates a Hardware object for each unknown worker.
enrollment: creates Hardware and Workflow objects for each unknown worker.
disabled: auto capabilities are disabled.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

@jacobweinstock jacobweinstock added the do-not-merge Signal to Mergify to block merging of the PR. label Jun 3, 2024
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 3.77358% with 102 lines in your changes missing coverage. Please review.

Project coverage is 27.41%. Comparing base (3d8f7d2) to head (0f604ba).

Files Patch % Lines
internal/server/auto.go 0.00% 36 Missing ⚠️
internal/server/kubernetes_api_workflow.go 12.90% 27 Missing ⚠️
cmd/tink-server/main.go 0.00% 23 Missing ⚠️
internal/server/kubernetes_api.go 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #946      +/-   ##
==========================================
- Coverage   28.04%   27.41%   -0.63%     
==========================================
  Files          70       71       +1     
  Lines        3484     3564      +80     
==========================================
  Hits          977      977              
- Misses       2445     2525      +80     
  Partials       62       62              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This adds the following auto capabilites:

discover: creates a Hardware object for each unknown worker.
enrollment: creates Hardware and Workflow objects for each unknown worker.
disabled: auto capabilities are disabled.

Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
This is needed when creating hardware and workflows
in auto enrollment mode. Otherwise we don't know where
and can't create the Kubernetes objects.

Signed-off-by: Jacob Weinstock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge Signal to Mergify to block merging of the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant