Skip to content

[DRAFT] BC + ResNet + LSTM #5

Closed
wants to merge 19 commits into from
Closed

[DRAFT] BC + ResNet + LSTM #5

wants to merge 19 commits into from

Conversation

Howuhh
Copy link
Contributor

@Howuhh Howuhh commented Mar 13, 2023

No description provided.

@Howuhh Howuhh requested a review from vkurenkov March 13, 2023 13:53
@Howuhh Howuhh changed the title BC + ResNet + LSTM [DRAFT] BC + ResNet + LSTM Mar 13, 2023

states, actions, *_ = batch
logits, rnn_state = actor(
states.permute(0, 1, 4, 2, 3).to(DEVICE).to(torch.float32),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

мб лучше einops?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

хз, я если честно его не очень понимаю, но если все за, то мб

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

у него просто более интуитивная форма, тут получается было бы "b t x y c -> b t c x y", что более интуитивно выглядит

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

то есть, понимать, что у эйнопса под коробкой происходит необязательно, чтобы input->output семантику улавливать

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а он точно не дает оверхеда?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

не уверен, надо чекать

@Howuhh Howuhh closed this Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants