Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with IPython #79

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Integration with IPython #79

wants to merge 8 commits into from

Conversation

arkhan
Copy link

@arkhan arkhan commented Nov 12, 2015

No description provided.

@matrixise
Copy link
Collaborator

Hi, sorry for this very late review, but you want to support IPython in erppeek, it's great.

but maybe you could change the dependencies and add ipython for the support.

Thank you

@jf---
Copy link

jf--- commented Jan 31, 2018

its great

👍 yes, very cool

but maybe you could change the dependencies and add ipython for the support

its an optional feature, so its shouldnt go in setup.py nor is it a requirement, a real dependency
my 2 cents is that this is acceptable.
log.info("IPython not found, vanilla python REPL used") to hint support for ipython` might be a gentle hint, but could be merged as is

@arkhan
Copy link
Author

arkhan commented Feb 9, 2018

ipython is optional, for this reason I do not think it is necessary to use it as a direct dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants