-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hci: implement set random MAC address #229
Conversation
I'm a bit hesitant with this PR because it's a bit more complicated than that: there are three different kinds of random MAC addresses. See this post for details: https://novelbits.io/bluetooth-address-privacy-ble/. This PR doesn't distinguish between the three, which means the API will need to change in the future. I plan on implementing private addresses in the bluetooth package eventually, after implementing pairing and bonding. |
Signed-off-by: Xudong Zheng <[email protected]>
Signed-off-by: Xudong Zheng <[email protected]>
8dc46b3
to
393949d
Compare
That sounds reasonable. I'll mark the PR as a draft for now until there is a bit more clarity around how MAC addresses should be stored internally. I'll keep this semi-updated as it's useful for #230. |
Hello @xudongzheng and @aykevl I was just looking at this PR, and thinking that it probably seems fine. Via the linked article:
The HCI controller command does not distinguish between different kinds of random addresses. See https://analog-devices-msdk.github.io/MAX-BLE-HCI/le_controller_cmds.html#set-random-address Creating a random address that fulfills the extra requirements of private addresses can be added using an additional API of some kind, but seems like something additional. As such, this PR probably seems like a good thing. Thoughts? |
Closing this PR since it was replaced by your commits in #325 Thanks for working on this @xudongzheng |
No description provided.