gps: improvements and corrections for config commands #834
Conversation
gps/ublox.go
Outdated
| nav5Cmd.DynModel = DynModeBike | ||
| nav5Cmd.FixMode = FixModeAuto | ||
| nav5Cmd.Put42Bytes(d.buffer[:]) | ||
| d.SendCommand(d.buffer[:42]) |
There was a problem hiding this comment.
Can't you return the SendCommend error? Here and everywhere else
There was a problem hiding this comment.
Basically due to the fact that there is a constant stream of updates coming from NMEA messages, the results from sending any UBX commands are getting lost. Better to just ignore them for now.
There was a problem hiding this comment.
I realized the problem was not that an error was being returned, even though that error might be not actually an error. My problem was that the code was stopping from sending subsequent commands on an error.
Now have improved the implementation to return error, and count on the caller to ignore/handle as needed.
Thanks for the feedback on that @soypat
This contains some improvements and corrections for the gps driver It adds some additional functions for different modes (automobile, bike, etc) and also ignores the return results from any config commands. Basically due to the fact that there is a constant stream of updates coming from NMEA messages, the results from sending any UBX commands are getting lost. Better to just ignore them for now. Signed-off-by: deadprogram <[email protected]>
deadprogram
force-pushed
the
gps-nmea-gsv
branch
from
9aba2c1 to
9bef89a
Compare
| GSA NMEASentenceType = "GSA" | ||
| GGA NMEASentenceType = "GGA" | ||
| GLL NMEASentenceType = "GLL" | ||
| GSV NMEASentenceType = "GSV" | ||
| RMC NMEASentenceType = "RMC" | ||
| VTG NMEASentenceType = "VTG" | ||
| ZDA NMEASentenceType = "ZDA" | ||
| TXT NMEASentenceType = "TXT" |
There was a problem hiding this comment.
If these are not arguments or needed as user facing API I'd keep them internal, unexported
There was a problem hiding this comment.
They are needed in user apps.
This PR contains some improvements and corrections for the
gpsdriver. It adds some additional functions for different modes (automobile, bike, etc) and also ignores the return results from any config commands.Basically due to the fact that there is a constant stream of updates coming from NMEA messages, the results from sending any UBX commands are getting lost. Better to just ignore them for now.