INT-2756: add statusbar attribute
#56
Conversation
lorenzo-pomili
requested review from
spocke,
TheSpyder,
ltrouton,
a team,
lostkeys,
hamza0867 and
vpyshnenko
and removed request for
a team
|
@spocke changelog entry added, have a look |
| @@ -48,6 +48,7 @@ const parseNumberOrString = (value: string) => /^\d+$/.test(value) ? Number.pars | |||
|
|
|||
| const configAttributes: Record<string, (v: string) => unknown> = { | |||
| setup: parseGlobal, // function | |||
| statusbar: parseBooleanOrString, // boolean | |||
There was a problem hiding this comment.
Should this be // boolean or string
There was a problem hiding this comment.
I thought the same, but it is a boolean: https://www.tiny.cloud/docs/tinymce/latest/statusbar-configuration-options/#statusbar
I think we both confused with toolbar
There was a problem hiding this comment.
Hmm, then parseBooleanOrString should be parseBoolean ?
There was a problem hiding this comment.
I used that because is what is used for other fields like powerpaste_allow_local_images and images_upload_credentials, maybe I'm wrong but the attribute will be always a string so even true and false will be "true" and "false"
There was a problem hiding this comment.
Right since they are all strings it needs to check for specific values or fallback to the string value. Makes sense now. I really should have spent time to look thought the webcomponent plugin this sprint but all other stuff came in between.
lorenzo-pomili
force-pushed
the
feature/INT-2756
branch
from
982da10
to
c9666e4
Compare
INT-2756
issue: #24