fix: concat strings and include verification status (#304)

tinyspeck · Aug 8, 2023 · 497928f · 497928f
1 parent 04a9a19
commit 497928f
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 17 deletions.
diff --git a/dist/index.js b/dist/index.js
@@ -32850,21 +32850,22 @@ function runPushAlert(args) {
             const commit = process.env.GITHUB_SHA;
             const reviewed = yield verifyCommitReview(client, commit);
             if (reviewed === false) {
-                const commitDetails = yield client.git.getCommit({
+                const commitDetails = yield client.repos.getCommit({
                     repo: github.context.repo.repo,
                     owner: github.context.repo.owner,
-                    commit_sha: commit,
+                    ref: commit,
                 });
                 //notify channel
                 var github_commit_url = `https://github.com/${github.context.repo.owner}/${github.context.repo.repo}/commit/${commit}`;
-                const message = `:red-c: @channel Unreviewed Commit in \`${github.context.repo.owner}/${github.context.repo.repo}\`\n` +
+                const message = `:red-c: <!channel> Unreviewed Commit in \`${github.context.repo.owner}/${github.context.repo.repo}\`\n` +
                     '\n' +
                     `*Commit:* <${github_commit_url}|${commit.slice(0, 6)}>\n` +
-                    `*Author:* <https://github.com/${encodeURIComponent(commitDetails.data.author.name)}|${safeSlackString(commitDetails.data.author.name)}>\n` +
-                    `*Committer:* <https://github.com/${encodeURIComponent(commitDetails.data.committer.name)}|${safeSlackString(commitDetails.data.committer.name)}>\n` +
+                    `*Author:* <https://github.com/${encodeURIComponent(commitDetails.data.author.login)}|${safeSlackString(commitDetails.data.commit.author.name)}>\n` +
+                    `*Committer:* <https://github.com/${encodeURIComponent(commitDetails.data.committer.login)}|${safeSlackString(commitDetails.data.commit.committer.name)}>\n` +
+                    `*Verified Commit:* ${commitDetails.data.commit.verification.verified ? ':check:' : ':red-bang:'} _${safeSlackString(commitDetails.data.commit.verification.reason)}_\n` +
                     '*Message:*\n' +
-                    '```\n';
-                safeSlackString(commitDetails.data.message) +
+                    '```\n' +
+                    safeSlackString(commitDetails.data.commit.message) +
                     '\n```';
                 const req = request.post(args.slackEndpoint, {
                     json: {

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "push-alert",
-  "version": "1.1.2",
+  "version": "1.1.3",
   "private": true,
   "description": "Push alert for monitoring unreviewed commits",
   "main": "dist/index.js",

diff --git a/src/push-alert.ts b/src/push-alert.ts
@@ -15,22 +15,23 @@ export async function runPushAlert(args) {
       const commit = process.env.GITHUB_SHA;
       const reviewed = await verifyCommitReview(client, commit);
       if (reviewed === false){
-        const commitDetails = await client.git.getCommit({
+        const commitDetails = await client.repos.getCommit({
           repo: github.context.repo.repo,
           owner: github.context.repo.owner,
-          commit_sha: commit,
+          ref: commit,
         });
 
         //notify channel
         var github_commit_url = `https://github.com/${github.context.repo.owner}/${github.context.repo.repo}/commit/${commit}`;
-        const message = `:red-c: @channel Unreviewed Commit in \`${github.context.repo.owner}/${github.context.repo.repo}\`\n` +
+        const message = `:red-c: <!channel> Unreviewed Commit in \`${github.context.repo.owner}/${github.context.repo.repo}\`\n` +
           '\n' +
           `*Commit:* <${github_commit_url}|${commit.slice(0, 6)}>\n` +
-          `*Author:* <https://github.com/${encodeURIComponent(commitDetails.data.author.name)}|${safeSlackString(commitDetails.data.author.name)}>\n` +
-          `*Committer:* <https://github.com/${encodeURIComponent(commitDetails.data.committer.name)}|${safeSlackString(commitDetails.data.committer.name)}>\n` +
+          `*Author:* <https://github.com/${encodeURIComponent(commitDetails.data.author.login)}|${safeSlackString(commitDetails.data.commit.author.name)}>\n` +
+          `*Committer:* <https://github.com/${encodeURIComponent(commitDetails.data.committer.login)}|${safeSlackString(commitDetails.data.commit.committer.name)}>\n` +
+          `*Verified Commit:* ${commitDetails.data.commit.verification.verified ? ':check:' : ':red-bang:'} _${safeSlackString(commitDetails.data.commit.verification.reason)}_\n` +
           '*Message:*\n' +
-          '```\n'
-          safeSlackString(commitDetails.data.message) +
+          '```\n' +
+          safeSlackString(commitDetails.data.commit.message) +
           '\n```';
         const req = request.post(args.slackEndpoint,{
           json:{