Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(misc): import teacher photos should only find staff #1740

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix(misc): import teacher photos should only find staff #1740

merged 1 commit into from
Dec 11, 2024

Conversation

NotFish232
Copy link
Member

Proposed changes

  • importing teacher photos should only consider staff users

Brief description of rationale

  • It would be awfully unfortunate if a teacher and a student both had the same names and the wrong image was loaded

@NotFish232 NotFish232 requested a review from a team as a code owner December 11, 2024 01:48
@alanzhu0
Copy link
Member

Yes that would be AWFULLY unfortunate

@coveralls
Copy link

Coverage Status

coverage: 79.157% (+0.06%) from 79.098%
when pulling 893580d on NotFish232:fix_import
into f80a619 on tjcsl:dev.

@NotFish232 NotFish232 merged commit a7ab927 into tjcsl:dev Dec 11, 2024
5 checks passed
@NotFish232 NotFish232 deleted the fix_import branch December 11, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NotFish232 @alanzhu0 @coveralls