Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): fix file downloads #1743

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

hstievat
Copy link
Contributor

Proposed changes

  • Allows for downloading files from the files app, including directories as zip files.
  • Before, the connection would timeout.

Brief description of rationale

When the response object was returned, the temporary file exited the context manager and closed itself automatically, creating a hidden error with the StreamingHttpResponse. By casting the FileWrapper to a list, the data is loaded into memory before the file is closed.

@hstievat hstievat requested a review from a team as a code owner December 28, 2024 19:09
@coveralls
Copy link

Coverage Status

coverage: 79.108% (-0.02%) from 79.123%
when pulling 2907535 on hstievat:files_fix
into 888a599 on tjcsl:dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants