Improve indicators API #6395
Open
Improve indicators API #6395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
steveruizok
commented
Jul 4, 2025
Comment on lines
35
to
43
| const path = editor.getPath() | ||
| const nodeIds = path.split('.') | ||
| for (let i = 0; i < nodeIds.length; i++) { | ||
| const subpath = nodeIds.slice(0, i).join('.') | ||
| const stateNode = editor.getStateDescendant(subpath) | ||
| if (!stateNode?.getShouldShowIndicators()) { | ||
| return prev | ||
| } | ||
| } |
There was a problem hiding this comment.
The main new logic
steveruizok
temporarily deployed
to
deploy-staging
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves a long-standing todo, which replaces the hard-coded list of "show indicators" to state nodes instead. As a result, we can remove the
<TldrawShapeIndicators>component that provided that logic.Change type
bugfiximprovementfeatureapiotherRelease notes
shouldShowIndicators()toStateNode, used to configure whether indicators should be shown when in the state