Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onboarding: "next" usability #4167

Conversation

jamesacklin
Copy link
Member

@jamesacklin jamesacklin commented Nov 12, 2024

  • Adds onSubmitEditing props to email fields so the user can press "enter" to submit the form via the system soft-keyboard
  • Relocates the "Next…" button on signup and login screens to a hero button beneath the field

Signup screen:
Simulator Screen Recording - iPhone 16 - 2024-11-12 at 14 25 49

Tlon login screen:
Simulator Screen Recording - iPhone 16 - 2024-11-12 at 14 27 01

…" button to hero beneath field on login and signup screens
Copy link

linear bot commented Nov 12, 2024

Copy link
Member

@latter-bolden latter-bolden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some nits

  • We have PrimaryButton which has a built in spinner
  • Could probably simply leave it as Sign up and omit the signup method
  • Feels a bit cramped visually, but whatever you see fit.
  • Eula stuff should already be on develop (still seeing it in the diff)

@jamesacklin
Copy link
Member Author

  • Eula stuff should already be on develop (still seeing it in the diff)

I merged that PR and merged develop back in here, so that's reflected :)

@jamesacklin jamesacklin merged commit b3e4003 into develop Nov 12, 2024
1 check passed
@jamesacklin jamesacklin deleted the james/tlon-3204-native-tapping-next-on-keyboard-when-email-input-is-ready branch November 12, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants