Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native: avoid calling branch from client #4180

Merged
merged 20 commits into from
Nov 15, 2024
Merged

native: avoid calling branch from client #4180

merged 20 commits into from
Nov 15, 2024

Conversation

latter-bolden
Copy link
Member

@latter-bolden latter-bolden commented Nov 13, 2024

For creating invite links we phone out to a new external service that talks to Branch itself. For looking up metadata associated with an invite link, we hit the provider instead of Branch.

For now, I still have it calling Branch on lookup since the provider is lacking some useful metadata (namely inviter nickname and avatar). But we fallback gracefully if that request fails, it's purely an enhancement. Going forward, I also updated it to add richer metadata to the provider (shoutout @arthyn for pointing me in the right direction there).

Also proxies our analytics to increase the odds they're able to make it into PostHog.

Note, you'll need to update your .env with the invite service vars:

# Invite service
INVITE_SERVICE_ENDPOINT="https://serverless-infra.vercel.app/api/inviteLink"
INVITE_SERVICE_IS_DEV="true"

Fixes TLON-3138

Copy link

linear bot commented Nov 13, 2024

@jamesacklin
Copy link
Member

We love you Brian

@jamesacklin
Copy link
Member

This works in production so...

@latter-bolden
Copy link
Member Author

Yeah reviewers are busy, I'm gonna merge it.

At this point, any issues we find with the code will need to be promptly addressed and deployed anyhow. If any of y'all notice anything weird just hmu.

@latter-bolden latter-bolden merged commit 6af04e5 into develop Nov 15, 2024
2 checks passed
@latter-bolden latter-bolden deleted the lb/no-branch branch November 15, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants