-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
native: avoid calling branch from client #4180
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We love you Brian |
This works in production so... |
Yeah reviewers are busy, I'm gonna merge it. At this point, any issues we find with the code will need to be promptly addressed and deployed anyhow. If any of y'all notice anything weird just hmu. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For creating invite links we phone out to a new external service that talks to Branch itself. For looking up metadata associated with an invite link, we hit the provider instead of Branch.
For now, I still have it calling Branch on lookup since the provider is lacking some useful metadata (namely inviter nickname and avatar). But we fallback gracefully if that request fails, it's purely an enhancement. Going forward, I also updated it to add richer metadata to the provider (shoutout @arthyn for pointing me in the right direction there).
Also proxies our analytics to increase the odds they're able to make it into PostHog.
Note, you'll need to update your
.env
with the invite service vars:Fixes TLON-3138