-
Notifications
You must be signed in to change notification settings - Fork 86
add support for Brainpool curves in TLS 1.3 (RFC8734) #529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9306e48
to
593c97d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feature-wise, it looks good to me, though I see quite a lot of if curve_name == ...
for those curves; perhaps they could be a dict lookup and defined in a single place for simplicity?
yes, I was thinking of this, but I think it will be better to combine that with the refactoring of the all the different places that do signing and verification |
a5b9abc
to
4b9763b
Compare
4b9763b
to
4128eb6
Compare
@ueno In the end I did create a define with all the special schemes... I've also fixed few bugs in handling of those signature schemes, please, take a look at it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add support for Brainpool curves in TLS 1.3, both for ECDH and signing
This change is