Feature: Validation #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit brings a validation handling on task creation. This implies additional changes integrated: - DaisyUI was upgraded - Hooks were implemented as using Taskchampion is not calling the original taskwarrior hooks anymore. - Undo report is getting the data now from taskchampion for better usability
tmahmood
approved these changes
Apr 6, 2025
|
Those are some nice improvements, (Sorry about the messy code btw), thank you Not able to give enough time right now, so anything you add would be great! I reviewed the changes quickly, it looks good. |
monofox
added a commit
to monofox/taskwarrior-web-rs
that referenced
this pull request
Apr 6, 2025
This commit fixes a bug introduced with ticket tmahmood#10 and MR tmahmood#13. The `mask_task_as_done` did what it was named for. It completed tasks. Due to this, it was not possible anymore, to re-activate a ticket back to pending.
monofox
added a commit
to monofox/taskwarrior-web-rs
that referenced
this pull request
Apr 6, 2025
This commit fixes a bug introduced with ticket tmahmood#10 and MR tmahmood#13. The `mask_task_as_done` did what it was named for. It completed tasks. Due to this, it was not possible anymore, to re-activate a ticket back to pending.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit brings a validation handling on task creation. This implies additional changes integrated:
Error indication:
Interestingly i figured out, that depending how you create the tags in the task command line interface, you will be able to assign invalid tags. Even with a sign in front of a tag. So it seems that taskchampion is better validating the data than task itself.
Undo report example:
I would not had to change the undo report yet. But my inner Monk forced me to do it. If I should split and send as separate request, let me know.
Closes #10
Dear @tmahmood ,
maybe you can try it out on your side whether this is working fine for you as well or if there are further improvements in this case necessary.
I've many further ideas in this, but do not want to bloat this MR too much. It contains already much more things i initial planned.
Best regards,
monofox