milvus: add skipFlushOnWrite option (#992)

milvus: add disableFlush option
tmc · Sep 13, 2024 · 0cab9df · 0cab9df
1 parent 47d2d99
commit 0cab9df
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/vectorstores/milvus/milvus.go b/vectorstores/milvus/milvus.go
@@ -36,6 +36,7 @@ type Store struct {
 	metricType       entity.MetricType
 	searchParameters entity.SearchParam
 	schema           *entity.Schema
+	skipFlushOnWrite bool
 }
 
 var (
@@ -226,8 +227,10 @@ func (s Store) AddDocuments(ctx context.Context, docs []schema.Document,
 	if err != nil {
 		return nil, err
 	}
-	if err = s.client.Flush(ctx, s.collectionName, false); err != nil {
-		return nil, err
+	if !s.skipFlushOnWrite {
+		if err = s.client.Flush(ctx, s.collectionName, false); err != nil {
+			return nil, err
+		}
 	}
 	return nil, nil
 }

diff --git a/vectorstores/milvus/options.go b/vectorstores/milvus/options.go
@@ -131,6 +131,13 @@ func WithMetricType(metricType entity.MetricType) Option {
 	}
 }
 
+// WithSkipFlushOnWrite disables flushing on write.
+func WithSkipFlushOnWrite() Option {
+	return func(s *Store) {
+		s.skipFlushOnWrite = true
+	}
+}
+
 func applyClientOptions(opts ...Option) (Store, error) {
 	s := Store{
 		metricType:       entity.L2,