Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agents: internationalize and add Chinese prompt #1001

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Alan796
Copy link
Contributor

@Alan796 Alan796 commented Aug 27, 2024

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

If non-English questions are inputed, the agents won't work well with the English prompt, so I'm internationalizing agents and adding Chinese prompt. Other languages can be supported too.

@Alan796 Alan796 changed the title internationalize agents: internationalize and add Chinese prompt Aug 27, 2024
Copy link
Owner

@tmc tmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for adding this, have a few nits.

i18n/load_agents.go Show resolved Hide resolved
i18n/lang.go Show resolved Hide resolved
@Alan796
Copy link
Contributor Author

Alan796 commented Sep 13, 2024

@tmc OK, thank you for the opinions, the nits are resolved, please review again.

@Alan796
Copy link
Contributor Author

Alan796 commented Sep 13, 2024

Wait, there are conflicts, I will resolve them now.

@Alan796
Copy link
Contributor Author

Alan796 commented Sep 13, 2024

OK, conflicts are resolved.

"action input": "工具参数:",
"observation": "结果:",
"output key": "输出:",
"system message": "你是一个牛逼的AI助手。",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"牛逼"非常精髓了!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"牛逼"这个词会不会让一些英文语料训练的大模型懵逼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants