Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

googleapi/vertex: fix multi-tool call error, Invalid argument #1027

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CloudAceEmma
Copy link

@CloudAceEmma CloudAceEmma commented Sep 21, 2024

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

This PR fix Invalid argument error when using multiple tools, google genai only support one tool, multiple tools must be embedded into function declarations, cc @eliben, see also:
GoogleCloudPlatform/generative-ai#636
https://cloud.google.com/vertex-ai/generative-ai/docs/multimodal/function-calling#chat-samples

Copy link
Collaborator

@eliben eliben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

initial comments

llms/googleai/googleai.go Outdated Show resolved Hide resolved
llms/googleai/shared_test/shared_test.go Show resolved Hide resolved
llms/googleai/googleai.go Outdated Show resolved Hide resolved
@eliben
Copy link
Collaborator

eliben commented Sep 24, 2024

LGTM

@tmc to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants