openaiclient: Fix updateToolCalls method for calls proxied with LiteLLM#1440
Open
dzbanek717 wants to merge 10 commits intotmc:mainfrom
Open
openaiclient: Fix updateToolCalls method for calls proxied with LiteLLM#1440dzbanek717 wants to merge 10 commits intotmc:mainfrom
updateToolCalls method for calls proxied with LiteLLM#1440dzbanek717 wants to merge 10 commits intotmc:mainfrom
Conversation
Author
|
Hello @tmc , any chance on reviewing this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using LiteLLM as LLM proxy for accessing multiple models with one LLM agent in streaming mode the parameter
type: functionis always provided due to API conversion on LiteLLM side.Despite the fact that it seems to be a problem on integration with LiteLLM side the whole problem lays in
updateToolCallsfunction check. The assumption thattypeis not provided seems to be based more on the observation, rather than actual contract.Basing on
function namenot being provided and part ofargumentsbeing provided this assumption seems to be also fine. Providing arguments for next tool shall always start with tool name. Therefore we are receiving parts of arguments until we received a new name. And it makes OpenAI Client compatible with both standard OpenAI API and LiteLLM proxy.PR Checklist
memory: add interfaces for X, Yorutil: add whizzbang helpers).Fixes #123).golangci-lintchecks.